Closed lcornelatti closed 8 months ago
Hey @emilhe , would appreciate a review here
@lcornelatti Thanks for the PR! This is most definitly a bug. I have made a single suggestion for an improvement. Once that is cleared out, I believe the PR can be merged.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
4392117
) 80.45% compared to head (24a8ae3
) 80.35%. Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
dash_extensions/enrich.py | 77.77% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes summary
end_server_id
component.Reason for changes
end_server_id
never being updated upon failure of the callback. In further calls of the callback, the clientside callback that ensures theblocking
behaviour still thinks the previous callback is being ran. This is only released afterblocking_timeout
Testing