search

emilhe / dash-extensions

The dash-extensions package is a collection of utility functions, syntax extensions, and Dash components that aim to improve the Dash development experience
https://www.dash-extensions.com/
MIT License
422 stars 59 forks source link

Serve locally: False - Cannot find package dash_extensions@1.0.14 #317

Open FRosner opened 7 months ago

FRosner commented 7 months ago

Hi! When I set serve_locally=False in my dash app that relies on dash-extensions, it fails with Cannot find package dash_extensions@1.0.14 when trying to fetch https://unpkg.com/dash_extensions@1.0.14/dash_extensions/dash_extensions.min.js. I can see that https://www.npmjs.com/package/dash-extensions exists. Is that the correct repo? If yes, why is it looking for _ and not -?

How can I make this work? :)

My poetry.lock:

[[package]]
name = "dash-extensions"
version = "1.0.14"
description = "Extensions for Plotly Dash."
optional = false
python-versions = ">=3.8,<4"
files = [
    {file = "dash_extensions-1.0.14-py3-none-any.whl", hash = "sha256:960201f8b184ed85fe2b77258030e64af1bb4555dd9bdcbd66923f0cf1ae837f"},
    {file = "dash_extensions-1.0.14.tar.gz", hash = "sha256:ef25293a35c3c3c3ba640c05380c9f047a5efdeb4ca650dc2075bc5899a34c63"},
]
FRosner commented 7 months ago

@emilhe is this something I can fix somehow? Maybe some -/_ mix-up I can address?

emilhe commented 7 months ago

I believe that the reason you face this issue is that the npm package is currently not published correctly. I would like to look into this at some point, but I haven't had the time yet. If you are able to correct the setup, I would be happy to look at a PR :)

FRosner commented 7 months ago

I believe that the reason you face this issue is that the npm package is currently not published correctly.

Do you think so @emilhe? From what I can tell dash-extensions should be the correct name? I think the reason could be that the python module is dash_extensions, while the package is called dash-extensions. Would you be fine to rename the npm package to dash_extensions? Not sure if there is another way to fix that.

FRosner commented 5 months ago

Any idea @emilhe?