search

emilianavt / OpenSeeFace

Robust realtime face and facial landmark tracking on CPU with Unity integration
BSD 2-Clause "Simplified" License
1.41k stars 151 forks source link

[SUGGESTION] officially support OpenSeeFace as a flatpak #43

Closed orowith2os closed 3 months ago

orowith2os commented 2 years ago

I am currently in the process of writing a Flatpak for OpenSeeFace, and have already gotten vpuppr (formerly openseefacegd) to work as a flatpak. I think it would be beneficial for OpenSeeFace to officially support being ran as a flatpak, as it allows for one command to install (literally just flatpak install) and it wouldn't break on system python upgrades. This would probably only be beneficial to Linux, and maybe any other UNIX-like OSes.

emilianavt commented 2 years ago

I have never used anything flatpak related. What would be required to support this?

orowith2os commented 2 years ago

Pretty much, all you'd need to support it is say "replace python facetracker.py for flatpak run osfflatpakhere" when I have the flatpak finished up.

orowith2os commented 2 years ago

Making progress. When I get the pip dependencies to install inside of the environment, it'll be ready to use. image

emilianavt commented 2 years ago

What I meant is, would all that would be needed to include some control file like with e.g. poetry, or would I also have to make some kind of additional builds to upload when releasing new versions?

orowith2os commented 2 years ago

It seems to be able to just build using the method of release you're doing now, so no extra work needs to be done. To build the flatpak, just modify the manifest to change the archive (or git commit) to build from and it'll build whatever you tell it to with little to no issue.

emilianavt commented 2 years ago

Thank you, that sounds good then.

orowith2os commented 1 year ago

Still not done, waiting on some bug fixes in the flatpak-builder tools. I'll take another look at using prebuilt binaries though.

emilianavt commented 1 year ago

Oh, if you're still working on it, I'll keep the issue open!