search

emilianbold / incubator-netbeans

Mirror of Apache Netbeans (Incubating)
Apache License 2.0
1 stars 11 forks source link

[NETBEANS-54] Module Review versioning.core #301

Closed trevlewis closed 7 years ago

trevlewis commented 7 years ago

For issue https://github.com/emilianbold/incubator-netbeans/issues/205

-Add to Apache License. -Update nbbuild/build.xml

trevlewis commented 7 years ago

@emilianbold I got all the whitespace issues taken care of and I got Netbeans set up.

trevlewis commented 7 years ago

@emilianbold Yes, I apologize for that. I was trying to get Netbeans set up and look at other PR's as well. I am all set up now so I should have no more simple mistakes like this. Thank you for your patience.

I am getting the excludes fixed right now.

emilianbold commented 7 years ago

Have you heard of Giotto’s perfect circle?

You aim should be to create a perfect commit and PR.

emilianbold commented 7 years ago

Sigh... in this block:

+# +# http://www.apache.org/licenses/LICENSE-2.0 +#

you have an extra space after '#' for the 'empty' comment lines.

trevlewis commented 7 years ago

That was copied for another file that was committed already, so not sure why mine needs to be different then what is already in the code, but I fixed the whitespaces after the empty comments.

emilianbold commented 7 years ago

$ grep -R -1 '^#.*http://www.apache.org/licenses/LICENSE-2.0' . | grep -v "http://www.apache.org/licenses/LICENSE-2.0" | grep -v '^--$' | grep -v '#$' | grep -v '^Binary file'

./spi.java.hints/src/org/netbeans/spi/java/hints/Bundle.properties-#

$ git log ./spi.java.hints/src/org/netbeans/spi/java/hints/Bundle.properties commit cc42f40263c42b1e5fc6dabb1b934229cf26ace5 Author: Trevor trevlewis@users.noreply.github.com Date: Fri Oct 6 08:06:01 2017 -0600

[NETBEANS-54] Module Review spi.java.hints