emilianotisato
commented
4 years ago Thanks Johannes, yes please if you can send a PR I'll merge it.
Emiliano
On Mon, Mar 23, 2020 at 10:47 AM Johannes Rückert notifications@github.com wrote:
Thank you for this amazing package 👍
One thing I noticed is that Nova uses different (CSS) classes when displaying errors, which results in two different font-sizes and font-styles being shown (if you combine this package with other Nova validations).
[image: demo] https://user-images.githubusercontent.com/4764281/77340304-67c2d880-6d2d-11ea-8ff8-d6ad467ce1be.png
Could you please consider matching the class names in order to avoid this "mismatch"?
Nova (I currently use v2.12.0) uses these classes for error messages:
.help-text.error-text.mt-2.text-danger
If you want, I can even create a PR for it.
Cheers and thank you
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emilianotisato/nova-google-autocomplete-field/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4C52YUJXIEB2KL7RKUTLRI6HDPANCNFSM4LSANG4A .
-- Emiliano Tisato Cloud Computing & API integration Specialist Google Partner & Analytics Guru Certified (+52) 044 56 1125 9499 emiliano@thormaweb.com
anotherfrontendguy
Thank you for this amazing package 👍
One thing I noticed is that Nova uses different (CSS) classes when displaying errors, which results in two different font-sizes and font-styles being shown (if you combine this package with other Nova validations).
Could you please consider matching the class names in order to avoid this "mismatch"?
Nova (I currently use v2.12.0) uses these classes for error messages:
If you want, I can even create a PR for it.
Cheers and thank you