search

emilianotisato / nova-google-autocomplete-field

Address Autocomplete with Google Place API (full metadata available)
20 stars 17 forks source link

Address Metadata also on placedata #5

Closed Skullbock closed 5 years ago

Skullbock commented 5 years ago

Needs recompile to be usable

emilianotisato commented 5 years ago

Hello @Skullbock,

Lease explain why this is useful? witch case scenario solve? (if possible clarify that on the readme file for the users of this package).

And please recompile and commit the production files also to this pull request.

Thanks!

Skullbock commented 5 years ago

It allows to use the addressmetadata field to store not only the informations in the address object but also those from the place object

I’ll do that next week very gladly 👍🏻

Il giorno sab 27 apr 2019 alle 15:23 Emiliano Tisato < notifications@github.com> ha scritto:

Hello @Skullbock https://github.com/Skullbock,

Lease explain why this is useful? witch case scenario solve? (if possible clarify that on the readme file for the users of this package).

And please recompile and commit the production files also to this pull request.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emilianotisato/nova-google-autocomplete-field/pull/5#issuecomment-487285906, or mute the thread https://github.com/notifications/unsubscribe-auth/AAINRUYXYVU3APCL4LP2VC3PSRHWPANCNFSM4HIVMSXA .

-- [image: Logo Weble] Daniele Rosario

CTO Weble Srl Via Enrico Fermi, 265 36100 Vicenza ufficio: +39 0444 1454934 <003904441454934> mobile: +39 3283017134 <00393283017134> weble.it https://www.weble.it/ https://www.facebook.com/pages/Weble/110077192371908?fref=ts https://twitter.com/Webleit?lang=it https://www.linkedin.com/company/2470613?trk=tyah&trkInfo=clickedVertical%3Acompany%2Cidx%3A2-2-7%2CtarId%3A1432717146425%2Ctas%3Aweble https://www.instagram.com/weble.it/

Skullbock commented 5 years ago

Updated as requested

nickpoulos commented 5 years ago

I think this PR could be causing #6. Is it possible that values are getting overwritten maybe? Not sure, but v0.6 seems to work ok, and then 0.7 is broken.

Skullbock commented 5 years ago

@nickpoulos i'll try to check it this week to better understand what's happening. It's possibile that they get overwritten, maybe it's better to introduce a dedicated method for the two different objects? Metadata and place type values?