search

emilianotisato / nova-tinymce

Laravel Nova TinyMCE editor (with images upload capabilities!)
MIT License
116 stars 38 forks source link

adds custom id option #18

Closed rubenestevao closed 4 years ago

rubenestevao commented 4 years ago

Fixes #19

emilianotisato commented 4 years ago

Nice @rubenestevao , thanks!

But please check your id() method because is overriding the default withMeta(), you need to merge the options that already came in withMeta array so no configuration is loosed.

Let me know when you fix that and please document this use case in the readme explaining why and when is necessary.

rubenestevao commented 4 years ago

Hi @emilianotisato,

I think no configuration is loosed because withMeta method merges internally. Am I missing something?

Screenshot 2019-12-09 at 10 56 41
emilianotisato commented 4 years ago

Yes, but I am not sure if because we already use it in other method, di both options arrays get merged with the parent one? If so, ok

On Mon, Dec 9, 2019 at 5:20 AM rubenestevao notifications@github.com wrote:

Hi @emilianotisato https://github.com/emilianotisato,

I think no configuration is loosed because withMeta method merges internally. Am I missing something? [image: Screenshot 2019-12-09 at 10 56 41] https://user-images.githubusercontent.com/5180651/70431799-b8137480-1a75-11ea-8932-147b73ccfbd1.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emilianotisato/nova-tinymce/pull/18?email_source=notifications&email_token=AEN4C5Y34TJSQ6T4SU5NOKDQXYSXNA5CNFSM4JVHKODKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIZYWA#issuecomment-563190872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN4C52TT5G6TAGHTWJTNYTQXYSXNANCNFSM4JVHKODA .

rubenestevao commented 4 years ago

Hi @emilianotisato, sorry for the delay. There is no problem use withMeta multiple times in that case. I put also the use case in the readme.