search

emilianotisato / nova-tinymce

Laravel Nova TinyMCE editor (with images upload capabilities!)
MIT License
116 stars 38 forks source link

Update to TinyMCE 6 and support for Nova 4 #66

Closed bashgeek closed 2 years ago

bashgeek commented 2 years ago

Quite a bigger update here.

This enables support for Nova 4 (which introduces Vue 3), but breaks it for Nova 3 or lower, so it should be released in a new major version I suppose. It also supports the native dark-mode from Nova 4.

Together with that, I updated the included TinyMCE to current version 6, this will require a few config changes if anyone upgrades to it (specifically the plugins list), please see the default config included.

bashgeek commented 2 years ago

@emilianotisato I do not want to be pushy here, just a general question about this: Do you plan on merging and releasing this in the near future (or at all) or should we move on with a fork instead? Kind of a blocker for us currently :-) Thanks so much!

emilianotisato commented 2 years ago

@bashgeek Thanks for this PR. Give me this week to review it and release it as major version upgrade.

Planning to add cypres tests for this package soon

bashgeek commented 2 years ago

@bashgeek Thanks for this PR. Give me this week to review it and release it as major version upgrade.

Planning to add cypres tests for this package soon

Sounds good, thanks!

bashgeek commented 2 years ago

@emilianotisato How's it looking so far? :-)

emilianotisato commented 2 years ago

@bashgeek I just merged under v2 . Thanks for this and sorry for the delay, I had little to no time pass week. I notice still not fully compatible with Nova 4 dependent fields api: https://nova.laravel.com/docs/4.0/resources/fields.html#dependent-fields

But I'll be working on that