search

emilioastarita / lyricfier

a Spotify Lyrics alternative app | New updates at https://github.com/emilioastarita/lyricfier2 (a faster version in golang)
Creative Commons Zero v1.0 Universal
586 stars 47 forks source link

Using local API to retrieve current track #104

Open jakub-tucek opened 6 years ago

jakub-tucek commented 6 years ago

Hey,

I made first version of changing API for retrieving current track to use local system api for spotify player as was suggested here: https://github.com/emilioastarita/lyricfier/issues/103 by @patrolez.

I only tested it on Linux but clients are for the most part taken from this project:

https://github.com/panz3r/hyper-spotify/tree/master/src/lib

Please take a look and let me know what you think.

patrolez commented 6 years ago

I am not a TypeScript developer, but I can only say well done! :+1:

It works under Linux for me also!

I wonder if @emilioastarita is still interested to maintain this repo :thinking:

Agusum commented 6 years ago

I've tried this in macOS Mojave and it's not working for me 😢

jakub-tucek commented 6 years ago

Thank for testing! I will take a look and see what I can do about it

mendel3 commented 6 years ago

Not working for me on Windows 10. In the cmd prompt, when clicking Try Again I get this [10628:1012/232907.571:INFO:CONSOLE(6)] "Uncaught TypeError: Spotilocal is not a constructor", source: C:\Users\myles\lyricfier\render\spotify\SpotifyWindows.js (6) I have spotify version 1.0.91.183.g259b84fa, but I also use Spicetify to customize my Spotify a bit. Could that be why this isn't working? Thanks!

jakub-tucek commented 5 years ago

I fixed issue on macOs Mohave so linux+macOs should work now.

Unfortunately, I had to remove support for windows as i have no idea how to do it locally. As MPRIS does not exists on windows and it seems SystemMediaTransportControls is not alternative that would allow accessing currently played track. I vote for dropping windows support until we find working alternative and in the meantime have working app for other platforms. What shall we do @emilioastarita?

Agusum commented 5 years ago

It works now! Thank you so much!

Is there a way you could put together a release so that it's easier to launch the app (not requiring the command line)?

jakub-tucek commented 5 years ago

Here is release in forked repo: https://github.com/jakub-tucek/lyricfier/releases/tag/v0.3.0

mendel3 commented 5 years ago

Is windows support a priority, because all other lyric apps for Spotify are abandoned

wappyn commented 3 years ago

(electron:15339): Pango-ERROR **: 22:07:44.628: Harfbuzz version too old (1.4.2)

I just done quick googling and find out that it's probably common electron problem, but I have no idea how to fix it.