Added translate function to lyrics - Githubissues

emilioastarita / lyricfier

a Spotify Lyrics alternative app | New updates at https://github.com/emilioastarita/lyricfier2 (a faster version in golang)

Creative Commons Zero v1.0 Universal

586 stars 47 forks source link

Added translate function to lyrics #82

Open renatonolo opened 7 years ago

renatonolo commented 7 years ago

This commit add a translate button to song screen, allowing the users to translate the lyrics.

To this button appear on song screen, you need to enable translate on Settings screen and choose a language to translate.

You can improve this function, creating TranslatePlugins, to get translated songs from another sources..

Please, analyze this and, if you have douts or questions, ask me, then we can solve the problems together.

Thanks.

emilioastarita commented 7 years ago

Hello @renatonolo thanks for submiting this PR. I've merged it and resolved conflicts with last master in this branch: https://github.com/emilioastarita/lyricfier/tree/translated-lyrics . I think that needs some work before to be merged on master. Do you want to work on it?

Update detectSeries to the same logic that now is using the lyric searcher.
Setting option Enable Translate to lyrics has not default on first launch (use Disabled).
Would be nice if after pressing Translate the interface scrolls to top (we are doing that on song change)
Remove unused vars.
If any API_KEY is needed this must be a configurable option for user in Setting. Add a link to the url where our user can obtain it.
Translate Lyrics button must not be visible when there is no lyrics yet.

Thanks! If you need any help let me kwnow.

renatonolo commented 7 years ago

Hello man. I'm back.

I saw your suggestions and I liked. Then, I already did the modifications, according your suggestions. About the API_KEY, I think that the developer of plugin need to add the API_KEY to the code and not the user. For example, in "vagalume" plugin you don't need to put API_KEY, then this variable is empty. What you think?

Can you see and analyze that to merge or not this modifications?

If you have questions, ask me.. :+1: See you...

emilioastarita commented 7 years ago

Ok I would check about API_KEY if this is private or not. Usually this could be a problem because multiple users share the same credentials so you hit soon to the rate limits of the APIs. Can you provide a link where I can investigate about TOS and conditions of the provider?

renatonolo commented 7 years ago

Yeah, you can see the documentation on: https://api.vagalume.com.br/docs/ But it's only on portuguese (PT-BR).. :/