search

emilioforrer / haml_coffee_assets

Haml Coffee templates in the Rails asset pipeline or as Sprockets engine.
https://rubygems.org/gems/haml_coffee_assets
MIT License
437 stars 146 forks source link

Support for Rails 7.2 #194

Closed adbelsham closed 3 months ago

adbelsham commented 3 months ago

Adds support for Rails 7.2.

mathieujobin commented 3 months ago

Can you please update the Changelog and bump the version as well?

mathieujobin commented 3 months ago

looks like 7.2 has to exclude ruby 3.0 unless we remove support for ruby 3.0 entirely as well ?

adbelsham commented 3 months ago

Can you please update the Changelog and bump the version as well?

This is done now.

adbelsham commented 3 months ago

looks like 7.2 has to exclude ruby 3.0 unless we remove support for ruby 3.0 entirely as well ?

I've added an exclude line, please approve the workflows to test this has resolved the problems.

adbelsham commented 3 months ago

Thanks for the review @mathieujobin I've actioned your comments, please re-run the tests and let me know if any further changes required.

mathieujobin commented 3 months ago

released and pushed to rubygems, thanks for your contribution @adbelsham