Open jsta opened 2 years ago
@jsta : wow, thanks for this contribution straight into github! My apologies for the delayed follow up. I'm tickled that you even found this stub, empty repo.
Several years ago I made some fairly small improvements to the code base, but never got around to pushing them out anywhere. I never tried to convert it to Python 3. Bear in mind that this code was written in 2007 - 2008, so it carries design decisions based on what was available then. For someone interested in it today, I keep wondering if it's not best to start a new code base from scratch based on Mayorga et al 2010 and using the GNE code base as a starting point. I would probably recommend using Pandas through and through, since the model operates largely on tables (Pandas didn't exist back then). Doing so should greatly simplify the code, I think. I'd be very interested in hearing about your interest in the Global NEWS / GNE model & code, perhaps offline. emiliom [at] uw.edu. After perusing your web site, I think we have a lot of common interests.
I'll accept your PR but might end up moving the files to a folder later on.
One more thing: the original code worked as is (maybe with minor tweaks, I forget) in a fresh Python 2.7 conda environment, or at least it did about two years ago.
I'm trying out the code and seem to have got it working. Things I did:
2to3
utilitySeems to be working:
original output
re-ran output
PR incoming...