search

emilioxavier / theHUB

https://theHopefulBox.com/
Other
2 stars 0 forks source link

`make.donut.data()` faceting option (via `facetBy`) is broken #14

Open emilioxavier opened 1 year ago

emilioxavier commented 1 year ago

when trying to create donut data with the option for facets, the facetBy parameter is not correctly implemented. the logic for what columns to create appears broken. does it matter if a facetting column is included if it is not used? could we just set it to NULL or NA?

emilioxavier commented 1 year ago

okay. after some investigating, looks like rewriting the function is the best idea to include facetBy and layerBy options. apparently, my hasty "fixes" in the previous version break the function more. 🤦

the layerBy option allows multiple rings. in a way, layers and facetting are interchangeable when used independently, but the real power comes when combined. using facetBy enforces the use of facets in the make.donut.plot() function.