search

emilis / summer-bandits

Summer Bandits SuperCollider project
0 stars 1 forks source link

Implement basic guitar strumming #13

Closed laurynaslubys closed 4 months ago

laurynaslubys commented 4 months ago

Adresses #3. Implemented basic guitar strumming, including using guitar like chords. The diff is bigger than it should be, but I accidentally formatted the main file and noticed it too late.

Here's a sample of playing this through the free "Ample Guitar M Lite" plugin.

Also I extended the harmony to expose the "flavour" (i.e. major, minor, etc) of each chord in a scale. There's got to be a better term for this, but I couldn't find it.

laurynaslubys commented 4 months ago

Implement a bunch more strumming patterns, they can be switched using midi notes 67-72 for demo purposes.

laurynaslubys commented 4 months ago

This doesn't take into consideration tension and energy levels, as I don't really understand the concept at the moment.

emilis-wix commented 4 months ago

I'm not a guitar player and to me it sounds very natural. Amazing job!

Tested it on my Yamaha MODX guitar category.

There are some glitches though: after some time MODX stops playing. I'm guessing it doesn't receive enough note-offs or something.

It is also hard to time the chord key and the strum key on the keyboard. It seems to me that pressing a chord key cuts off the playing notes. Should it be like this, or should we only cut off what's playing on Up/Down?

emilis-wix commented 4 months ago

I think the "my MODX stopped playing" bug happens in the FullStrumming mode.

We were playing a CombinedStrumming for some time and it worked OK. Then we switched to FullStrumming and my MODX stopped playing after a short time.

laurynaslubys commented 4 months ago

I'm not a guitar player and to me it sounds very natural. Amazing job!

Tested it on my Yamaha MODX guitar category.

There are some glitches though: after some time MODX stops playing. I'm guessing it doesn't receive enough note-offs or something.

You're probably right, I was hoping to get away with sending all notes off, but it's possible some devices don't play well with that.

It is also hard to time the chord key and the strum key on the keyboard. It seems to me that pressing a chord key cuts off the playing notes. Should it be like this, or should we only cut off what's playing on Up/Down?

That's kind of what happens on a guitar. We should test how if feels on the controller, then we can decide what we should do. But yes, you do need to time it right. To me it feels ok, when you're the one switching chords, not sure how it would feel in follower mode.

I suggest we merge this and I'll update #3 with the comments and concerns from here.