search

emilk / eframe_template

The easy way to make a Rust app with a GUI
Apache License 2.0
785 stars 176 forks source link

404 on sw.js github pages #132

Closed rukh-debug closed 4 months ago

rukh-debug commented 4 months ago

image

I have been trying to deploy on github pages, but I am getting 404 on sw.js, hence, website is not rendeding anything. Everything works fine locally on trunk serve. Serving a http page locally over WAN works fine aswell. but github page seems to have trouble running it.

Thats my github page config inside the repo setting. image

Here's the workflow for github page: https://raw.githubusercontent.com/rukh-debug/rukh-debug.github.io/main/.github/workflows/pages.yml

I tried setting public url to:

  1. public_url: "https://${{ github.repository_owner }}.github.io/${{ github.event.repository.name }}"
  2. public_url: "https://rubenk.dev"
  3. public_url: "https://${{ github.repository_owner }}.github.io"

but none seems to work as expected. It's mostly 404 on sw.js

Any leads would be greatly appreciated. Thank you for maintaining!

Demo: http://rubenk.dev/ Repo: https://github.com/rukh-debug/rukh-debug.github.io

rukh-debug commented 4 months ago

image

Changing deploy branch to gh-pages fixed the issue. my bad.