search

emilk / eframe_template

The easy way to make a Rust app with a GUI
Apache License 2.0
823 stars 181 forks source link

Fix `index.html` links to `manifest` and `apple-touch-icon` #142

Closed Its-Just-Nans closed 5 months ago

Its-Just-Nans commented 5 months ago

Bug: assets have incorrect paths

Proof:

git clone https://github.com/emilk/eframe_template.git && lychee .
  31/31 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                              Issues found in 1 input. Find details below.

[./eframe_template/index.html]:
✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/icon_ios_touch_192.png | Failed: Cannot find file
✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/manifest.json | Failed: Cannot find file

🔍 31 Total (in 0s) ✅ 29 OK 🚫 2 Errors

Fix

change links to these assets

Related to

emilk commented 5 months ago

Thanks!

jnises commented 4 months ago

After this commit I get this warning when trying to use eframe_template with trunk: Manifest: Line: 1, column: 1, Syntax error.

Looks to me like trunk (0.20.2) copies files specified using <link data-trunk rel="copy-file" href=" to the root of the dist directory. So prepending assets/ to the manifest.json url breaks things.

Its-Just-Nans commented 4 months ago

After this commit I get this warning when trying to use eframe_template with trunk: Manifest: Line: 1, column: 1, Syntax error.

Looks to me like trunk (0.20.2) copies files specified using <link data-trunk rel="copy-file" href=" to the root of the dist directory. So prepending assets/ to the manifest.json url breaks things.

Thanks for reporting it