emilk / loguru

A lightweight C++ logging library
The Unlicense
1.77k stars 256 forks source link

Rename signals to signal_options #161

Closed puzzlepaint closed 3 years ago

puzzlepaint commented 3 years ago

This PR proposes to rename the SignalOptions member in Options from signals to signal_options. This avoids issues if the popular Qt library, which defines a macro called signals (see https://doc.qt.io/qt-5/signalsandslots.html), is included before loguru.

The install_signal_handlers function already calls its argument const SignalOptions& signal_options.