Open kcgen opened 3 years ago
Re-sync'd with latest changes in master
.
Recently merged PR#180 introduce two new PVS Studio warnings:
This branch now fixes these as well, in commit: https://github.com/dosbox-staging/loguru/commit/0155fe9552c470754e1c1919d3cf7f7df90a21ff
This PR fixes issues flagged by the Clang static analyzer, Coverity, and PVS Studio. Suggest reviewing commit-by-commit, for which the following provides more background.
Uninitialized member variables, flagged by GCC and PVS Studio
Unused position increment (clarify intent), flagged by Clang's static analyzer
Simplify empty
std::string
operations (1/2), flagged by PVS StudioSimplify empty
std::string
operations (2/2), flagged by PVS StudioPotential nullptr dereference, flagged by PVS Studio
Clarify criteria by removing redundancy, flagged by PVS Studio
If it makes sense to keep keep them, I could see them be valid as assert
s or
CHECK_F`s -- let me know.Virtualize EcEntryBase's destructor so it's called by derived classes, flagged by LGTM
Explicitly ignore sigaction's return value, flagged by Coverity