search

emilk / loguru

A lightweight C++ logging library
The Unlicense
1.76k stars 256 forks source link

Undeclared use of identifier 'pthread_getname_np' when building under OpenBSD/amd64 7.1-stable #225

Open morgant opened 2 years ago

morgant commented 2 years ago

I'm working on updating the eduke32 port for OpenBSD to the latest release, which has since migrated to using loguru. When building under OpenBSD/amd64 7.1-stable, the following error is generated:

source/build/src/loguru.cpp:1152:5: error: use of undeclared identifier 'pthread_getname_np'; did you mean 'pthread_get_name_np'?
    pthread_getname_np(pthread_self(), buffer, length);
    ^~~~~~~~~~~~~
    pthread_get_name_np
/usr/include/pthread.np.h:50:6: note: 'pthread_get_name_np' declared here
void pthread_get_name_np(pthread_t, char *, size_t);

This is because OpenBSD's pthread_get_name_np() implementation does not alias pthread_getname_np like FreeBSD does.

Reviewing loguru.cpp, it appears that there are some attempts at OpenBSD support, including in the set_thread_name() & get_thread_name() implementations. However, while the set_thread_name() implementation seems to correctly use pthread_set_name_np() for FreeBSD & OpenBSD, unfortunately the get_thread_name() implementations doesn't have similar platform support and just tries to use pthread_getname_np().

morgant commented 2 years ago

I'll submit a patch, but I'm curious whether you prefer to have the logic defined in get_thread_name(), like it currently is in set_thread_name(), or would it be better to just appropriately alias pthread_getname_np & pthread_setname_np for OpenBSD with a macro? The latter seems cleaner to me at this time.

seanm commented 10 months ago

I have a patch here if anyone can review/test: https://github.com/emilk/loguru/pull/245