search

emilk / loguru

A lightweight C++ logging library
The Unlicense
1.76k stars 256 forks source link

Fix building on MinGW #230

Closed punchready closed 1 year ago

punchready commented 1 year ago

See https://github.com/gabime/spdlog/commit/da8024854e6ca7b9fd2fdd254e0d00558279fc7d for a similar fix in a different logging library.

neheb commented 1 year ago

https://github.com/emilk/loguru/pull/233 is probably better.

punchready commented 1 year ago

That one also contains a change to the thread_local declaration that was rejected by the repo owner before, as far as I understand.

neheb commented 1 year ago

My point is it's probably better to include unconditionally.