emilkowalski / vaul

An unstyled drawer component for React.
https://vaul.emilkowal.ski
MIT License
5.29k stars 170 forks source link

Drawer is jittery scrolling down when `modal={false}` is set #253

Open ghost opened 5 months ago

ghost commented 5 months ago

https://codesandbox.io/p/devbox/nested-modal-with-input-2-6wt446

Repro:

Expected: Drawer will close as it does when modal={true}. Seen: Drawer doesn't close and jitters and gets stuck.

emilkowalski commented 5 months ago

Does it only happen when the modal prop is set to false?

ghost commented 5 months ago

Yeah, that’s what I noticed, you can try it yourself in the codesandbox

On Sat Feb 3, 2024, 08:30 PM GMT, Emil Kowalski @.***> wrote:

Does it only happen when the modal prop is set to false? — Reply to this email directly, view it on GitHub https://github.com/emilkowalski/vaul/issues/253#issuecomment-1925448249, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6TXO6XHR7XAH7XT2ZQ776LYR2NAFAVCNFSM6AAAAABCXELISOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGQ2DQMRUHE. You are receiving this because you authored the thread.Message ID: @.***>

predaytor commented 4 months ago

Can confirm this. modal={false} is broken currently.