Cannot scroll when new element is added in drawer

emilkowalski / vaul

An unstyled drawer component for React.

https://vaul.emilkowal.ski

MIT License

6k stars 201 forks source link

Cannot scroll when new element is added in drawer #317

Open DawnMD opened 6 months ago

DawnMD commented 6 months ago

In the drawer there is a form, but if the booking code is not valid a new element is added making the submit button pushed below the usable viewport Anything I'm doing wrong here? The correct solution would be that the drawer will auto calculate the height of new element is added?

https://github.com/emilkowalski/vaul/assets/34785917/ed965b5a-3b24-4006-b3e5-95d338bf19fc

pandas9 commented 5 months ago

same issue here, was able to fix it by making inner content scrollable but it's not usable for input at all and package hasn't been updated for months

DawnMD commented 5 months ago

@pandas9 but making the inner content scrollable seems a bad UX 😢

didair commented 5 months ago

+1 Also seeing this issue. I have added an inner content scroll for now. Tried adjusting the height property set on the root overlay but doesnt seem to make a difference.

e-Naeim commented 4 months ago

I have the same issue. I use form input, when the error messages are displayed, it pushes everything down.

is there a fix without scrolling? thanks.