search

emilkowalski / vaul

A drawer component for React.
https://vaul.emilkowal.ski
MIT License
6.46k stars 215 forks source link

Contain CSS file in the published package #417

Closed huozhi closed 2 months ago

huozhi commented 2 months ago

The css file was output by tsup into the dist/ before, this PR manually copy the css into ./style.css since there're users relying on it already.

Updated the readme to clarify the usage. This could be a workaround solution for users having CSP restrictions

Closes #283 Closes #357

vercel[bot] commented 2 months ago

@huozhi is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vaul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 4:08pm
vchirikov commented 2 months ago

@huozhi / @emilkowalski there is no vaul/style.css or vaul/dist/style.css in 0.9.4 npm package.

huozhi commented 2 months ago

@emilkowalski Wonder if it's a publishing issue, if I do the publish dry-run it contains the style.css in the local package

npm notice 📦  vaul@0.9.4
npm notice Tarball Contents
npm notice 1.1kB LICENSE.md
npm notice 7.4kB README.md
npm notice 4.2kB dist/index.d.mts
npm notice 4.2kB dist/index.d.ts
npm notice 71.1kB dist/index.js
npm notice 69.8kB dist/index.mjs
npm notice 1.8kB package.json
npm notice 5.8kB style.css
npm notice Tarball Details
wong2 commented 1 month ago

I'm using v1.0.0, import 'vaul/style.css' results in an error:

[plugin:vite:import-analysis] Missing "./style.css" specifier in "vaul" package

I found a similar case https://github.com/vitejs/vite/issues/6480#issuecomment-1011937533