emilkowalski / vaul

A drawer component for React.
https://vaul.emilkowal.ski
MIT License
6.42k stars 215 forks source link

Drawer is broken for Iphone devices when opening a new one while closing another [v0.9.4 and v0.9.3] #433

Closed maiconcarraro closed 1 month ago

maiconcarraro commented 2 months ago

Codesandbox: https://codesandbox.io/p/devbox/drawer-non-dismissable-forked-qtt8jp?workspaceId=0f47f685-6d3f-426b-b796-e3a871dffa37&embed=1&file=%2Fpackage.json

This issue only happens when using the Iphone device itself, when using Chrome dev tools to emulate it doesn't trigger the same behavior. In v0.9.2 this is not an issue, only for v0.9.3 and v0.9.4.

Recording of the issue:

https://github.com/user-attachments/assets/5e01420d-5e1f-4387-94bb-3d3e8dfdc2e6

Iphone information: image

renekahr commented 2 months ago

Same for me. I also can't open nested drawers. This is only the case on iOS, though.

KirdesMF commented 2 months ago

Updating to 0.9.4 and we have nearly the same issue in our app.

If there is only one drawer on a page, there is no issue but once there 2 or more drawers the issue is happening. It becomes impossible to open any drawer.

Happens on iOS and Android.

maiconcarraro commented 2 months ago

@KirdesMF we don't have this issue for android, do you face this on web as well? Unfortunately Iphone is hard to debug for my environment, if I could reproduce w/ android I'd share more information to help emil

KirdesMF commented 2 months ago

@maiconcarraro No issue at all on web. About Android one of our dev tried on a android mobile and get the same issue. We tried to debug with Xcode but nothing really helpful.

maiconcarraro commented 2 months ago

@KirdesMF if your dev can debug the android using chrome inspect https://developer.chrome.com/docs/devtools/remote-debugging

emilkowalski commented 1 month ago

Fixed in #436. Will release a new version after I do some more manual testing and improvements.