search

emillind / zulip

Zulip server - powerful open source team chat
https://zulip.org/
Other
0 stars 1 forks source link

Refactor: Change local variables and method of using "subject" to "topic" in markdown.js #25

Closed wh1temustang closed 6 years ago

wh1temustang commented 6 years ago

close #14

Added this requirement in docs:

ID: FR (?) Title: class markdown should be able to add link of topic to a message. Description: class markdown contains method add_topic_links to add link of a topic to a message after received a message. Priority: Low Verifiability: (Tests for this can probably be found in markdown.js) Code refactor: markdown.js, echo.js Test refactor: markdown.js Refactor content: change local variable and methods which use “subject” instead of “topic”.

joakimboman commented 6 years ago

The test ./tools/lint fails because of the commit messages. (the first letter after the colon needs to be a capital letter)

Otherwise it all works.