Pass requirements

[emillind]

• [x] The work carried out is commensurate with the expected time spent (30 hours per person). The contribution of each group member is documented. Note: this is more important for this assignment as we will have to document exactly what people did, see the report template on the assignment page.
• [x] The changes affect the code and/or functionality of the software, not just documentation or other non-executable artifacts.
• [x] At least some refactorings are non-trivial in the sense that they do not all affect only single, local functions, but at least multiple functions, units, classes, files, or modules.
• [x] Requirements related to the functionality targeted by the refactoring are identified and described in a systematic way. Each requirement has a name (ID), title, and description, and other optional attributes (in case of P+, see below). The description can be one paragraph per requirement.
• [x] Changes to the test suite are shown and documented, e.g., as a patch.
• [x] Tests are automated, their outcome is documented, e.g., as a test log.
• [x] Key features affected by the refactoring are shown in UML class diagrams (before/after). Note: you do not have to show classes, fields, or methods that are not changed, unless they help with the overall understanding.
• [x] The overall work carried out, and experience gained, are documented. In particular, mention your experience about the given documentation/examples of the project, its tool framework, and the interaction within your team and with the community of the project.

[joakimboman]

We have started writing requirements in this google doc: https://docs.google.com/document/d/1uc1XwpS5DV0yealRePy40FjzDezzrENjyfpvVV_xjHE/edit?usp=sharing

[eywoon]

UML draft: UML It's not overly detailed, not sure how detailed they want it. Also it just gets a bit awkward with the detailing in JS. At leasts states the functions that will be changed.

[eywoon]

Marked points 2 and 3 as we pass this. 2 we can see in the UML and the dependencies between some classes. 3 many of the functions are only local but not nearly all of them, we could have an example ready for one of the bigger classes maybe.

[Aweponken]

For no 7 I guess we could generate a new UML and compare it with the first one? Is that enough?

[eywoon]

I think you should ask the TA for this. I can't think of an UML diagram that actually shows the changes that we've made as they are contained within functions as variables :/

[joakimboman]

We have made two separate before & after pages in draw.io

The after contains the updated function names, hopefully that should be enough

[eywoon]

Yeah I can't see what else they would tell us to do.