emillind / zulip

Zulip server - powerful open source team chat
https://zulip.org/
Other
0 stars 1 forks source link

Pass requirements #3

Open emillind opened 6 years ago

emillind commented 6 years ago
joakimboman commented 6 years ago

We have started writing requirements in this google doc: https://docs.google.com/document/d/1uc1XwpS5DV0yealRePy40FjzDezzrENjyfpvVV_xjHE/edit?usp=sharing

eywoon commented 6 years ago

UML draft: UML It's not overly detailed, not sure how detailed they want it. Also it just gets a bit awkward with the detailing in JS. At leasts states the functions that will be changed.

eywoon commented 6 years ago

Marked points 2 and 3 as we pass this. 2 we can see in the UML and the dependencies between some classes. 3 many of the functions are only local but not nearly all of them, we could have an example ready for one of the bigger classes maybe.

Aweponken commented 6 years ago

For no 7 I guess we could generate a new UML and compare it with the first one? Is that enough?

eywoon commented 6 years ago

I think you should ask the TA for this. I can't think of an UML diagram that actually shows the changes that we've made as they are contained within functions as variables :/

joakimboman commented 6 years ago

We have made two separate before & after pages in draw.io

The after contains the updated function names, hopefully that should be enough

eywoon commented 6 years ago

Yeah I can't see what else they would tell us to do.