search

emiln / clojirc

A simple event-based IRC library.
Eclipse Public License 1.0
1 stars 0 forks source link

Should accept underscore in hostnames #16

Closed Mikkeren closed 10 years ago

Mikkeren commented 10 years ago

The command parser for private messages currently will return an error if a message from a nick with an underscore is received. This is a possibility on most networks, and should be rectified.

emiln commented 10 years ago

You know what? Let's disregard all attempts to follow the spec and simply allow all non-whitespace chars as hostchars. I think this will make for a more resilient parser. I'm on it.

emiln commented 10 years ago

Could you give an example of a message failing parsing? It would be nice for the test suite. You can strip out all sensitive information.

emiln commented 10 years ago

This would have been closed with the acceptance of #17 had I mastered the pull request keyword magic.