search

emiln / clojirc

A simple event-based IRC library.
Eclipse Public License 1.0
1 stars 0 forks source link

Improve parser resilience #17

Closed emiln closed 10 years ago

emiln commented 10 years ago

This is in response to issue #16.

A hostchar currently consists of a regex explicitly allowing certain characters. This is not a very pleasing solution as networks may use all kinds of characters in their host strings. Furthermore, the whitelist approach serves no real purpose as the structure of a message guarantees that the hostchars will be followed by a space.

The new solution is just simply allow any non-whitespace characters as hostchars.

Accepting this pull request fixes issue #16.

Mikkeren commented 10 years ago

This passes the nickname I was having problems with in #16, and still works for other nicknames, so I see no reason not to merge it.