emilsjolander / StickyListHeaders

An android library for section headers that stick to the top
Apache License 2.0
5.51k stars 1.52k forks source link

Android O Beta - java.lang.IllegalStateException: Handling non empty state of parent class is not implemented #477

Open NLLAPPS opened 7 years ago

NLLAPPS commented 7 years ago

Is this project still maintained? Every now and then I get above error on Android O Beta. I guess it is related the OS but just heads up

Stack trace:

Java.lang.IllegalStateException: Handling non empty state of parent class is not implemented at se.emilsjolander.stickylistheaders.StickyListHeadersListView.onSaveInstanceState(StickyListHeadersListView.java:1098) at android.view.View.dispatchSaveInstanceState(View.java:17157) at android.view.ViewGroup.dispatchSaveInstanceState(ViewGroup.java:3668) at android.view.ViewGroup.dispatchSaveInstanceState(ViewGroup.java:3674) at android.view.ViewGroup.dispatchSaveInstanceState(ViewGroup.java:3674) at android.view.View.saveHierarchyState(View.java:17140)

sandy-8925 commented 7 years ago

I can confirm, this error happens only on Android O for us, and seems to happen only on Nexus/Pixel devices.

Edit: Was mislead by API level 25 in crash reports, looks like Android O reported API level 25 for a while.

NLLAPPS commented 7 years ago

As far as I know it only happens on Android O. It might be a bug with the platform

mtotschnig commented 7 years ago

With O and maybe earlier, the assumption that StickyListHeaderListView class relies on (that the super class does not have any state of its own to safe) no longer necessarily holds true. On my fork I tried to implement proper handling of this new situation: https://github.com/mtotschnig/StickyListHeaders/commit/c9f9a44cb689320fa2e22496460a83264d1b3020

chrisonline commented 7 years ago

@mtotschnig Great, thanks. Do you have a compile url for gradle for your fork? Because this library seems is discontinued and won't get any fix.

mtotschnig commented 7 years ago

@chrisonline Yes it can be included via Jitpack: https://jitpack.io/#mtotschnig/StickyListHeaders/master-SNAPSHOT

NLLAPPS commented 7 years ago

@mtotschnig There might be an issue with your implementation. I had a crash in the app, unrelated to your code but trace kept showing me your implementation about saved state. I was not able to capture it. I will post details if I can recreate it

NLLAPPS commented 7 years ago

Ah! Error exactly as @nvquockhtn posted at https://github.com/mtotschnig/StickyListHeaders/commit/c9f9a44cb689320fa2e22496460a83264d1b3020

Cylix commented 7 years ago

I got this issue from crashlytics too (Java.lang.IllegalStateException: Handling non empty state of parent class is not implemented).

Did you find a way to reproduce it? I setup Android O on a virtual device on Android Studio (nexus pixel xl) but everything works fine. If it happens in the onSaveInstance, I expect it to happen on some configuration change, but no way to reproduce it (I tried to rotate, lock, switch from one app to another, whatever, everything works fine).

I'd like to at least be able to reproduce it so that I can be sure that the fix works. So, if you have any clue about how to trigger the exception, I'd be suuuuper glad!

sandy-8925 commented 7 years ago

I was able to reproduce on actual physical device (Nexus 6P with Android O) when launching a different activity from the activity containing StickyListHeadersListView in it's view hierarchy.

On Mon, Jun 26, 2017, 2:05 PM Simon Ninon notifications@github.com wrote:

I got this issue from crashlytics too (Java.lang.IllegalStateException: Handling non empty state of parent class is not implemented).

Did you find a way to reproduce it? I setup Android O on a virtual device on Android Studio (nexus pixel xl) but everything works fine. If it happens in the onSaveInstance, I expect it to happen on some configuration change, but no way to reproduce it (I tried to rotate, lock, switch from one app to another, whatever, everything works fine).

I'd like to at least be able to reproduce it so that I can be sure that the fix works. So, if you have any clue about how to trigger the exception, I'd be suuuuper glad!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/emilsjolander/StickyListHeaders/issues/477#issuecomment-311181564, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyszwn778H7UdexgwuB5F_veFmZuhL9ks5sIB0GgaJpZM4Nvc9T .

NLLAPPS commented 7 years ago

I was not able to reproduce it on Nexus 5x with latest Android beta but got many crash reports from Nexus 6P when launching a different activity from the activity with StickyHeaders. I wonder if it is related to device.

Sloy commented 7 years ago

I didn't reproduce it with a virtual device either. But with a physical Nexus 6P it happened all the time.

Cylix commented 7 years ago

Thanks for your replies! Yeah, unfortunately, I do not have nexus 6P or pixel, only a Nexus 6 but there is no way to install Android O on it apparently, so I guess I have no way, for now, to reproduce on my side. Thank again for the quick replies :)

mtotschnig commented 7 years ago

By the way, you can increase the probability of reproducing the crash by setting "Don't keep activities" in the systems' developer settings.

crucibond commented 6 years ago

Hi, I am facing similar issue and were anyone able to solve this?

java.lang.IllegalStateException: at se.emilsjolander.stickylistheaders.StickyListHeadersListView.onSaveInstanceState (StickyListHeadersListView.java:1029)

mtotschnig commented 6 years ago

It is solved in https://github.com/mtotschnig/StickyListHeaders/releases/tag/2.7.1 . Use it via Jitpack compile 'com.github.mtotschnig:StickyListHeaders:2.7.1'

madhacked commented 6 years ago

@emilsjolander any plans to bring in @mtotschnig fixes? I'd prefer not to add Jitpack to my project! Thanks!

Cylix commented 6 years ago

@madhacked this project is 100% not maintained anymore, the last commit is dated from 2015. I don't think you should expect any plans. Best case would be someone forking this repo and maintaining the fork.

edisonw commented 6 years ago

fyi @madhacked and those who do not want to use jitpack or the additional support library dependency:

I have compiled the aar off master + 1 proper fix commit (https://github.com/edisonw/StickyListHeaders/commit/3dd88a2ad789ec24f369be35a8494ccf9379a07e)

The download link is here:

https://github.com/edisonw/StickyListHeaders/blob/master/release-2.7.2.aar

Everyone feel free to rename and download it locally if needed.

Note the correct way to use an aar file, if your file is inside /projectRoot/app/libs/sticky-list-headers.aar,

You need to declare this in your root dependency configuration:


        flatDir {
            dirs project(':app').file('libs')
        }

And then you can use it as compile(name:'sticky-list-headers', ext:'aar')

jungc commented 6 years ago

Hey guys,

@mtotschnig's personal forks had changes other than the problem addressed above. I've created a fork with his solution to the problem without any other changes. PR: https://github.com/jungc/StickyListHeaders/pull/1 It has been merged to master on my fork Also, I changed the version number to "2.7.1-FORK" in case this project ever gets maintained again.

Where to get the .aar file for your project :) https://github.com/jungc/StickyListHeaders/releases/tag/2.7.1-FORK

NOTE: 1. This change comes from Groupon. 2. We won't maintain it.

haemi commented 6 years ago

@jungc how can I install/use this fork?

dapda commented 6 years ago

Mute

Vào 11-10-2017 07:34, "Jaden Choi" notifications@github.com đã viết:

Hey guys,

@mtotschnig https://github.com/mtotschnig's personal forks had changes other than the problem addressed above. I've created a fork with his solution to the problem without any other changes jungc#1 https://github.com/jungc/StickyListHeaders/pull/1 Also, I changed the version number to "2.7.1-FORK" in case this project ever gets maintained again.

**NOTE:

  1. This change comes from Groupon.
  2. We won't maintain it.**

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emilsjolander/StickyListHeaders/issues/477#issuecomment-335638152, or mute the thread https://github.com/notifications/unsubscribe-auth/ATBBl750ctjbzkois8-BGV-v0OvvsYwzks5sq_7zgaJpZM4Nvc9T .

jungc commented 6 years ago

@haemi thanks for pointing that out. I've uploaded the .aar file here https://github.com/jungc/StickyListHeaders/releases/tag/2.7.1-FORK

haemi commented 6 years ago

@jungc thanks, I did that but I get failed to resolve: se.emilsjolander:stickylistheaders:stickylistheaders:

I updated my app-build.gradle:

repositories {
    maven { url "${rootDir}/local_repos" }
    jcenter()
    maven { url 'https://maven.fabric.io/public' }
    google()
}
implementation "se.emilsjolander:stickylistheaders:stickylistheaders:2.7.1-FORK@aar"

file is here:

local_repos/se/emilsjolander/stickylistheaders/2.7.1-FORK/stickylistheaders-2.7.1-FORK.aar
haemi commented 6 years ago

@jungc help pleeeeease...

jungc commented 6 years ago

@haemi @Sloy sorry about the delay. It looks like I made a typo with the previous release draft. It took me awhile to notice but it should be: implementation "se.emilsjolander:stickylistheaders:2.7.1-FORK@aar" :) <group id>:<artifact id>:<version>@aar^

brianguertin commented 6 years ago

Hey guys, you don't have to use a fork; the extra saved state comes from the autofill framework.

Disable autofill on the StickyListHeadersListView, and it will work fine.

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
  myList.setImportantForAutofill(IMPORTANT_FOR_AUTOFILL_NO_EXCLUDE_DESCENDANTS);
}

Of course, if you WANT autofill in your list view, then this workaround is not for you :)

CsabaZz commented 6 years ago

@brianguertin thanks, it's working perfectly!

ykphuah commented 6 years ago

@brianguertin Thanks, it works. Strange that I have two list with sticky headers and this issue only happen to one of them. I tried to compare the two and they seems exactly the same. Only one of them need your "fix".

Thanks again!

prince3156 commented 6 years ago

Android 25 the same issue occured.

kohterachai commented 6 years ago

420 Xposed v89 SDK26 crash on module download page

kohterachai commented 6 years ago

@NLLAPPS

Sent from my A37f using FastHub

etsjrkdtuif commented 6 years ago

I am extending StickyListHeadersListView:

public class CustomStickyListHeadersListView extends StickyListHeadersListView {
....
    @Override
    public void setImportantForAutofill(int mode) {
       if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
            super.setImportantForAutofill(IMPORTANT_FOR_AUTOFILL_NO_EXCLUDE_DESCENDANTS);
       }
    }
....
}

this does not work for me, still crashing...

peshkira commented 6 years ago

@HoriaGoran Do you call your method then? You have just overriden it, but you probably never call it?

etsjrkdtuif commented 6 years ago

I did call it. If you look at the View.java, onSaveInstanceState() it has this condition:

if (mStartActivityRequestWho != null || isAutofilled() || mAutofillViewId > LAST_APP_AUTOFILL_ID) {

So even if isAutofilled() will be false with the proposed fix, its is enough for 1 of the other 2 checks to be true and to return a non empty state for the exception to be thrown. I think this is the reason why the fix with setImportantForAutofill didn't work in my case. I fixed this by importing one of the forked libs mentioned in the thread.

SolveBugs commented 6 years ago

@brianguertin Excuse me, can say in detail how to use the code you have shown above,thanks a lot.

SolveBugs commented 6 years ago

@brianguertin I have already solved, thanks again。

hendrawd commented 6 years ago

autofill framework breaks everything :(

hendrawd commented 6 years ago

@mtotschnig I tried your solution, but there is an error when running the app. Program type already present: se.emilsjolander.stickylistheaders.CheckableWrapperView Do you know how to fix it except disabling R8 and D8?

hendrawd commented 6 years ago

Looks like, one of my modules also using this library, so I had to change both of my module-level build.gradle and app-level build.gradle, clean and rebuild to make it work.

gigabitese commented 5 years ago

colleagues that same error happens in android 9 I get the same error when debugging java.lang.IllegalStateException: Handling non-empty state of parent class is not implemented !! help !!

NiranjanaSekar commented 4 years ago

any alternative or fix for this?. Issue is when editing search view and set text works on marshmallow, not working in pie.

Failed to resolve: se.emilsjolander:stickylistheaders:2.7.1

sarithnob commented 2 years ago

This case is seen on crashlytics for me too. But it happened on Android 12, Pixel 4 XL and Pixel 3 XL. Anyways, I can't reproduce the crash on Emulator of the same device's model and OS.

440791217 commented 2 years ago

收到

CL-window commented 2 years ago

Hello,我已收到邮件,待我仔细阅读后再回复。

trifagabriel commented 2 years ago

I was able to solve this by setting .setSaveEnabled(false) on the agenda list view

thinkmobilede commented 2 weeks ago

I was able to solve this by setting .setSaveEnabled(false) on the agenda list view

actually this solved the issue for me in Android 15 while setImportantForAutofill did not.

CL-window commented 2 weeks ago

Hello,我已收到邮件,待我仔细阅读后再回复。

440791217 commented 2 weeks ago

收到