search

emilsvennesson / kodi-espnplayer

ESPN Player for Kodi
Other
4 stars 3 forks source link

Fixed plugin for latest site. #4

Closed mdklein closed 7 years ago

mdklein commented 7 years ago

espnplayer updated their site a while back and it broke your plugin. I finally had a little time to investigate, and got it working again.

I still need a live game to verify the "Live" category is working, but I think I got everything else figured out. Will verify tomorrow night.

I have only tested with NCAA, as I don't have an indycar/select sub.

emilsvennesson commented 7 years ago

Hi and thanks for the PR! It looks great.

I actually started rewriting this myself a couple of days ago, but never got around to syncing the changes to GitHub... sorry about that. I felt like the current Kodi-specific code was way too messy so I have started rewriting most of it from scratch and split it up some of the common functions in a KodiHelper class. I still have a lot left to do, but hopefully I'll find some time to finish it up soon.

It looks like you've come a longer way with the espnlib (it's now called 'ESPNPlayer') so if you could rebase and split the commits I have not yet implemented/updated (get_token, get_pkan, get_stream_url) I'd be very happy to merge it.

Thank you and sorry again for the duplicate efforts.