emilsvennesson / kodi-viaplay

Viaplay for Kodi
GNU General Public License v3.0
30 stars 19 forks source link

Support for Kodi 19 Matrix #44

Closed zebbe152 closed 3 years ago

zebbe152 commented 3 years ago

Are there any plans to make this add-on compatible with Kodi 19 Matrix?

SweXtal commented 3 years ago

There are a couple of issues.

First, prior versions <19 used Python 2.x, where Kodi 19 uses Python 3.x. That's the "not compatible" issue.

In windows, you go to %USERPROFILE%\appdata\roaming\kodi\addons\plugin.video.viaplay

in addon.xml you have two choices what to do. Fix A: edit the line containing "import addon="xbmc.python" version="2.25.0"" and replace 2.25.0 with 3.0.0 which is the Kodi 19 xbmc.python repo Fix B: Edit the line containing '' and comment the whole line out so it reads <!-- <import addon="xbmc.python" version="2.25.0" /> -->

in directory '%USERPROFILE%\appdata\roaming\kodi\addons\plugin.video.viaplay\resources\lib' some things has changed and you have to do some editing there too.

edit the viaplay.py and:

edit the kodihelper.py and:

I've coded Python for about one hour, in total so this gives further errors but it seems more related to JSON. B-)

ravenrocks commented 3 years ago

Hi SweXtal. Have you found a way to actually play videos in Matrix, the changes above makes it open fine and all, but not play anything.

SweXtal commented 3 years ago

No. As I wrote, this was during my first ever experience of python. I'm a complete noob at this and I don't have time to become a superhero pythonist. It seems that between Kodi 18.x and 19x something also changed in the JSON. Hence the faults. I am NOT an experienced Python nor Kodi programmer. I just want to state that and make it clear. This is walking in a minefield for me....

SweXtal commented 3 years ago

FYI the "hotpatch" above works (but it still doesn't work) with both the Repo release and the streaming sports fix released 3 months ago. I simply CAN NOT say that these "fixes" doesn't break compatibility with 18.x Kodi nor that it will sprinkle gold and sparkles over you. This is what I figured out in one hour, reading the Kodi logfile. Like everybody should.,

SweXtal commented 3 years ago

I welcome a second opinion here. Especially about why in Kodi 19 the Cookies doesn't get set. Heelp! Experienced Kodi/Python guys and gals....

emilsvennesson commented 3 years ago

Duplicate of #41.