search

emilsvennesson / kodi-viaplay

Viaplay for Kodi
GNU General Public License v3.0
30 stars 19 forks source link

Future maintenance #55

Open Beanow opened 2 years ago

Beanow commented 2 years ago

Hi @emilsvennesson @Mariusz89B Thanks for your work on this addon :] I wanted to reach out to you, about your thoughts for the addon going forward.

In an earlier discussion https://github.com/emilsvennesson/kodi-viaplay/pull/50#issuecomment-896712043 you discussed not having time/motivation, and collaborating in this repository. Though it looks like https://github.com/Mariusz89B/kodi-viaplay is independently being worked on.

I'm personally interested in making the addon more useful for myself (mostly watching Dutch F1) and happy to take on a few issues, for example profile support (#34) I've figured out how to do and got an ugly version working.

Before going off on my own, risking a 3rd fork, I'd like to hear your thoughts and figure out where to collaborate. :clap:

emilsvennesson commented 2 years ago

Hi @Beanow @Mariusz89B!

I'm happy that you guys are still maintaining/want to maintain this add-on as I haven't had the time to do it myself for quite some time! This was a project I started to get familiar with programming, and the code base kind of reflects that haha! There's a lot of room for improvement, but I haven't had the time or motivation to do the much needed refactor. Ideally, that's what I would have wanted before adding new features but perhaps it's fine "as long as it works".

I will probably not have time to dig into this until at least summertime, so I will happily add you both as collaborators (and sorry @Mariusz89B for forgetting to do so the last time we talked about it) to this repository as long as you stick to the GPL license and split up your work into separate commits. :-)

Mariusz89B commented 2 years ago

Hi Guys, well I forked this add-on to add some fixes and hadn't any plans on maintaining it, my main purpose was to learn about kodi plugins as I only worked with scripts. I can add you guys as collaborators if you like to keep it running as I'm currently not having the time to keep it updated.

Beanow commented 2 years ago

It's been all Mariusz to be honest. I just added one PR so far.

So I understand none of us are really intending to maintain.

Still think it would be nice to collaborate on one repo. I would suggest either:

as long as you stick to the GPL license

:ok_hand: no problem with me (the license would require that anyway)

and split up your work into separate commits

:ok_hand: good idea in general :]

What about reviews, do you want to look at changes and approve them?

Mariusz89B commented 2 years ago

@Beanow @emilsvennesson I have some folks currently working on the add-on in my repo, I have sent you guys invites. I also turned on issues as I wasn't aware of it being disabled.

Beanow commented 2 years ago

Thanks, I got your invite @Mariusz89B.

I wasn't aware of it being disabled.

It's the default for forks I believe. Makes sense for people who are forking only to submit PRs upstream, not to maintain it. It may be confusing to have two repositories with issues open though.

heppix commented 2 years ago

Hey, since Mariusz have no time to maintain it anymore I decided to take it and keep it in life. I have no much experience in maintaining Kodi add-ons so it's good time to learn something new :) We have forked it with @zuzia-dev, the source code you can find here: https://github.com/zuzia-dev/kodi-viaplay Also I have my private repository for my skins and kodi add-ons as well so I pushed it there, so everyone can simply download it and keep it updated: https://heppen-dev.github.io Hope you are guys are fine with it. We are open on any PR as far as it will works and don't break anything :) We want to keep it solid and stable like @emilsvennesson did.