emilsvennesson / script.module.inputstreamhelper

A simple Kodi module that makes life easier for add-on developers relying on InputStream based add-ons and DRM playback.
MIT License
133 stars 49 forks source link

Fix for select_best_chromeos_image. #534

Closed horstle closed 1 year ago

horstle commented 1 year ago

Until now, select_best_chromeos_image actually only used less than half of the hwids in the list, since many don't have that space after the name.

In the long run, I think it is better to use the board names, since there are multiple hwids/code names which use the same image. The name of the image always contains the board name. That will also make life easier if they switch from the 32bit to 64bit lib, cause we only have to change one board name, instead of checking for all code names.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information