emilsvennesson / script.module.inputstreamhelper

A simple Kodi module that makes life easier for add-on developers relying on InputStream based add-ons and DRM playback.
MIT License
133 stars 49 forks source link

Create option to choose Widevine version to install from repo. #538

Closed horstle closed 1 year ago

horstle commented 1 year ago

Closes #537

Test zips: script.module.inputstreamhelper-0.5.10-install_choosable-9c46011.zip script.module.inputstreamhelper-0.5.10+matrix.1-install_choosable-9c46011.zip

CastagnaIT commented 1 year ago

tested on a clean Kodi 21 but when i choosed re-install CDM addon is crashed https://paste.kodi.tv/awemenexiy.kodi

horstle commented 1 year ago

Your system apparently doesn't have setuptools, so the addon uses a deprecated method as fallback, but the variable returned by that is not hashable. Should be fixed now. I also updated the zips in the original comment.

CastagnaIT commented 1 year ago

Your system apparently doesn't have setuptools

on Windows kodi have python embedded dont use system installed python

tested new link above but now raise another error: https://paste.kodi.tv/gokojoyetu.kodi

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

horstle commented 1 year ago

Right, stupid mistake...

Fixed and new zips in the start post.

CastagnaIT commented 1 year ago

yes now works thanks just a little improvement, after you installed an older CDM version it immediately ask to update to last version if you have just installed an old version, there is no point in asking me to update to the latest version immediately imo this operation that should be automatically skipped and delayed on the specified days

horstle commented 1 year ago

Actually it does that. After the install finished, you probably didn't us "OK" to exit the settings. The addon stores the install time in a hidden setting, but that doesn't actually get saved, if you don't press "OK". It's basically the same issue as #421.