search

emilybache / GildedRose-Refactoring-Kata

Starting code for the GildedRose Refactoring Kata in many programming languages.
https://youtu.be/Mt4XpGxigT4
MIT License
3.75k stars 5.19k forks source link

cpp cpptexttest shows unidiomatic C++ #263

Closed PeterSommerlad closed 2 years ago

PeterSommerlad commented 3 years ago

I would think, that the text output could make use of iostreams or fmt instead of using C's printf. but may be that is part of the refactoring exercise?

emilybache commented 3 years ago

It's not intended as part of the refactoring, actually. The texttest fixture is not really meant to be edited, it should just work. At least that's the idea. Use of printf is just my lack of skill with C++ :-) I'd welcome a pull request to fix it.

AlganOngun commented 2 years ago

I opened a pull request to fix this issue #330