search

emilybache / GildedRose-Refactoring-Kata

Starting code for the GildedRose Refactoring Kata in many programming languages.
https://youtu.be/Mt4XpGxigT4
MIT License
3.77k stars 5.2k forks source link

Rider doesn't detect unit tests in csharpcore exercise #526

Closed dancodehq closed 8 months ago

dancodehq commented 8 months ago

Rider doesn't detect the NUnit unit tests in the csharpcore project, possibly due to the project setup. Because the unit test project is configured as a console application, I assume that the unit tests aren't being recognized. It's not commonplace to have your unit test project be a console application.

My suggested fix is to have three projects:

Further instructions for the approval testing also wouldn't go amiss as it's not clear how they should be used.

codecop commented 8 months ago

The setup of the different languages is inconsistent. Some put texttestsfixture into main, others into test. Would moving TextTestFixture.cs to gilderose project and making it a console application work?

dancodehq commented 8 months ago

Yes I think that might work!

codecop commented 8 months ago

I would be happy to receive a PR from you

dancodehq commented 8 months ago

Cool, I'll look over it this weekend. Thanks codecop!

dancodehq commented 8 months ago

My bad. I was running Rider 2023.2.3 which doesn't support NUnit 4. I upgraded and everything works out of the box. No PR needed! 😊

For anyone else having this issue, update your Rider!