Why are there 3 c# projects?

emilybache / GildedRose-Refactoring-Kata

Starting code for the GildedRose Refactoring Kata in many programming languages.

https://youtu.be/Mt4XpGxigT4

MIT License

3.76k stars 5.2k forks source link

Why are there 3 c# projects? #541

Closed StefH closed 5 months ago

StefH commented 5 months ago

I see these 3 C# projects?

These are all very similar; whould it make sense to just keep the csharpcore and rename this to csharp ?

codecop commented 5 months ago

Yes csharp and csharpcore look similar, both using Nunit - could be merged/unified. The xunit one is set up using xunit and should stay like that. Other languages have different folders for different testing frameworks, too

StefH commented 5 months ago

OK. I see.

Maybe a good idea to merge the csharpcore and csharp and rename that new project to csharp-Verify.NUnit and rename csharpcore-Verify.xunit to csharp-Verify.xUnit.

Or also remove the Verify from both so that we end up with:

csharp-NUnit / csharp.NUnit
csharp-xUnit / csharp.xUnit

I can make a PR.

codecop commented 5 months ago

Yes good idea to drop the verify word. Yes looking forward to your PR

codecop commented 5 months ago

Solved by #542