Whitespace and minor warnings in Java/Leaderboard

emilybache / Racing-Car-Katas

Several code katas on a racing car theme

https://youtu.be/ldthYMeXSoI

MIT License

302 stars 351 forks source link

Whitespace and minor warnings in Java/Leaderboard #8

Closed codecop closed 9 years ago

codecop commented 9 years ago

Emily, while doing the kata I formatted the code and fixed some minor warnings. Driver should have a hashcode as it is used as key in a map.

emilybache commented 9 years ago

Thankyou so much for this! You clearly have better idomatic Java than me :-) This fixes a number of issues with the Java translation. Unfortunately I've realized there is a serious bug in this code - if two drivers have the same number of points, the "driverRankings" method will drop one of them! I struggled to translate from the Python or Scala, which I don't think have this problem. Do you have any good ideas about how to fix this?

codecop commented 9 years ago

thanks, "better idomatic Java" - not sure this is a good thing nowadays ;-)