search

emilypi / Base16

BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

[feat] add the `parseBase16` function #26

Closed MangoIV closed 1 year ago

MangoIV commented 1 year ago

Hi, I have noticed, that there's only predicates on ByteStrings but none that actually give you back the Base16 ByteString, I have added such a function

MangoIV commented 1 year ago

@emilypi may you consider doing a hackage release for this?

emilypi commented 1 year ago

@MangoIV there's a lot to do here to cmplete the PR and make it amenable for a new release:

  1. Port the parseBase16 function to the rest of the modules
  2. Write a test suite for it
  3. Write the deprecations for isBase16 and isValidBase16

If you want to do that, I'd happily accept your PR, otherwise, I've got a bit of legwork to do to make it fit for release.