search

emilypi / smash

Smash products, Wedge products, and other Pointed stuff
34 stars 11 forks source link

rewrite some functions in point-free style #24

Closed subttle closed 3 years ago

subttle commented 3 years ago

Per discussion in https://github.com/emilypi/smash/issues/22. Additionally I thought swapWedge was a good candidate so I added that even though I hadn't explicitly listed it prior in the issue. Please let me know if you would like me to make any edits. Thanks!

subttle commented 3 years ago

Hmm the build seems to be failing with:

src/Data/Can/Lens.hs:147:10: error:
    Not in scope: type constructor or class ‘Swapped’
    A data constructor of that name is in scope; did you mean DataKinds?
    Perhaps you meant ‘Wrapped’ (imported from Control.Lens)
    |
147 | instance Swapped Can where
    |          ^^^^^^^
cabal: Failed to build smash-lens-0.1.0.1.
src/Data/Can/Lens.hs:147:10: error:
    Not in scope: type constructor or class ‘Swapped’
    A data constructor of that name is in scope; did you mean DataKinds?
    Perhaps you meant ‘Wrapped’ (imported from Control.Lens)
    |
147 | instance Swapped Can where
    |          ^^^^^^^
cabal: Failed to build documentation for smash-lens-0.1.0.1.

I didn't touch any of the Lens code so it would take me some time to figure out. Hopefully I'll have some time to look into it soon. Sorry for the inconvenience.

emilypi commented 3 years ago

Yeah, the lens bounds need to be tightened. I have a PR out for that. I'll have it in today and that should unblock you

subttle commented 3 years ago

Okay, great! No rush, thanks for the update!

emilypi commented 3 years ago

@subttle alright, other PR is merged, and your CI should be good to go if you merge master into this branch.