emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
219 stars 45 forks source link

[Request] A way to hide sidebars if they're empty #185

Open aaronhowser1 opened 1 year ago

aaronhowser1 commented 1 year ago

I like having the left sidebar as favorites, but 90% of time I don't have any favorites. image A way to remove everything but the page switch button when the panel is empty would be very much appreciated.

emilyploszaj commented 1 year ago

I didn't initially comment on this when I tagged it. I believe it'd definitely be a good idea to include an option like this, but I've been considering the most intuitive functionality for a long time.

Also worth consideration is subpanels. If the primary content of a sidebar is empty, but the subpanels are populated, should it still hide?

Here are my current conclusions, I feel like in a majority of situations, if a user is using subpanels, they will always be populated, so in combination with hiding settings, subpanels should just be ignored, if a user doesn't want hiding they'd just not enable it. I think the hybrid solution might be the most intuitive, presenting the button only if alternative populated sidebar types exist to display.

As an unrelated comment, there currently exists the option to simply remove the header for a sidebar, and I personally use this for the sidebar where I keep my favorites, as I don't value the page information. I don't see this as a proper solution to sidebar hiding, but I thought I'd mention it.

aaronhowser1 commented 1 year ago

there currently exists the option to simply remove the header for a sidebar

Oh I totally must have missed this! Where's the option for it? Is it per sidebar?

emilyploszaj commented 1 year ago

Yeah it's a setting you can set per each of the 4 sidebars, along with stuff like size, background, subpanels, etc, I believe it's called "Header"

Jaximo98-dev commented 1 year ago

What about hidding arrows and the number of pages when there's only one? And maybe center the favorites icon? Reduced visual noise when there's no use to displaying buttons that can't do much unless you move to the next page.

Maybe something similar could be expanded to other sidebars?