emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
221 stars 46 forks source link

[EMI 1.1.0+1.20.1+forge] Percentaged output in recipe tree #432

Closed ghost closed 5 months ago

ghost commented 5 months ago

EMI indicates in the recipe that an item has a probability (here 50%) for the recipe (here cutting board) as an output. But in the recipe tree it doesn't show ~8 (4/50%) wild rice like in the fabric version.

Installed mods: EMI 1.1.0+1.20.1+forge Create 1.20.1-0.5.1.f JEI 15.3.0.1 Farmer's Delight 1.20.1-1.2.4 2024-02-08_13 48 35 2024-02-08_13 49 28

emilyploszaj commented 5 months ago

This is a bug with farmer's delight

ghost commented 5 months ago

No, Create also doesn't work

emilyploszaj commented 5 months ago

Create forge also doesn't implement an EMI plugin to communicate chance

ghost commented 5 months ago

Both mods use "chance" in the recipe JSON files to get this item only at the defined percentage

Create example: { "type": "create:crushing", "ingredients": [ { "item": "minecraft:gravel" } ], "processingTime": 250, "results": [ { "item": "minecraft:sand" }, { "chance": 0.1, "item": "minecraft:flint" }, { "chance": 0.05, "item": "minecraft:clay_ball" } ] }

Farmer's Delight example:

{ "type": "farmersdelight:cutting", "ingredients": [ { "item": "farmersdelight:wild_rice" } ], "result": [ { "item": "farmersdelight:rice" }, { "chance": 0.5, "item": "farmersdelight:straw" } ], "tool": { "tag": "forge:tools/knives" } }

EMI just cannot handle the "chance" for its recipe tree calculations.

emilyploszaj commented 5 months ago

Vanilla has no concept of chance, what these mods are doing is adding a tooltip that mentions chance for JEI. JEI has no concept of chance, EMI does. A mod with an EMI plugin can specify its recipes have a chance for consumption/production.