search

emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
221 stars 46 forks source link

Indicate on EmiStackInteraction that recipe is nullable #455

Closed shartte closed 4 months ago

shartte commented 4 months ago

While unrelated to this change, I was bitten by EmiStackInteraction's shorter constructor setting clickable to true by default, since it overrides my slot default behavior :-)

In any case, since I now know that I need to use the full constructor to set clickable to false, I noticed that recipe is not actually marked as nullable, even though it is.

emilyploszaj commented 4 months ago

I'm relatively inconsistent on nullability annotation but this seems like one I definitely should've had.