emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

Support for custom tag types #483

Closed pupnewfster closed 2 months ago

pupnewfster commented 3 months ago

I am adding a few custom EmiStack types, and would like a way to also teach EMI about their corresponding tags. From doing a brief glance through my github/viewing usages in my IDE), I believe the main spots that would need some sort of support are:

I might have missed some use cases as I didn't setup an EMI workspace to browse the actual code, but I think I found at least a good start.

Version: 1.1.1+1.20.4

emilyploszaj commented 3 months ago

It may push my next update back but I would like to get this in as soon as possible, as I believe it wouldn't be too unreasonable. Right now the core features of tag integration are specifying a registry, class, and a way to construct a stack from an element of that registry, which is not unreasonable. Additionally, a method for appending to the tooltip between the name and the mod name would be reasonable, but perhaps it'd be better for this to be automatic based on the amount rendering solution required for #482. I'll just have to poke around and see, but I imagine these bugs will be linked.

emilyploszaj commented 2 months ago

This was implemented in the latest release