Cleanup build.gradle files

emilyploszaj / emi

A featureful and accessible item and recipe viewer

MIT License

220 stars 46 forks source link

Cleanup build.gradle files #486

Closed pupnewfster closed 3 months ago

pupnewfster commented 3 months ago

Make use of lazy configuration which is the way of defining things that gradle has been slowly moving towards
Fixes all gradle 9 warnings that are not just warnings of architectury loom as a plugin
Fix source jars for neo not generating properly (#469). I am effectively just making both source jars for neo be filtered now instead of just the filtered one, as the remapper seems to crash when it encounters JEMI classes as JEI isn't on the classpath

emilyploszaj commented 3 months ago

Modern Gradle sure looks a lot worse than it used to... Did you check that the artifacts generated from the various loaders all look correct (or, well, better, in the case of neo)? I generally don't like touching Gradle since I have so many different projects and artifacts to screen, heh. Hopefully I can merge these changes back to 1.19.2, I'll have to take a look and see if the build system is gathering tech debt.

pupnewfster commented 3 months ago

I published it to maven local and am building and running against the neo one in dev, and can properly see the sources for it there.

emilyploszaj commented 3 months ago

https://github.com/emilyploszaj/emi/actions/runs/8398429595/job/23003265915 Ah, this has broken my release system. Do you know any quick resolution to this?

emilyploszaj commented 3 months ago

Was able to resolve it, gradle's always headaches it seems.

pupnewfster commented 3 months ago

Sorry, I missed it, I guess I didn't look closely enough at the curseforge/modrinth blocks in part given the plugins weren't actually loaded as I didn't have keys for them set.