emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

Make special recipes return the proper backing recipe #487

Open pupnewfster opened 3 months ago

pupnewfster commented 3 months ago

Emi version: 1.1.4+1.20.4

Currently custom recipes that use synthetic ids (such as shulker box coloring recipes), don't return the actual backing recipe from EmiRecipe#getBackingRecipe. It would be helpful to have them store a reference to the actual RecipeHolder and then return that, rather than using the default implementation of looking the holder up from the recipe manager, as it fails because of them using synthetic ids.