search

emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

fix #366 #512

Open Phoupraw opened 2 months ago

Phoupraw commented 2 months ago

Not backward compatible.

(My IDE seemed to re-arrange the imports.)

emilyploszaj commented 2 months ago

You'll need to fix the import situation for this to be merged and reviewed correctly.

Phoupraw commented 2 months ago

You'll need to fix the import situation for this to be merged and reviewed correctly.

What's the correct import order? I can make my IDE sort them according to the order.

emilyploszaj commented 2 months ago

Whatever order they started in, I don't have a formal definition

Phoupraw commented 2 months ago

Is this OK?

emilyploszaj commented 2 months ago

This still seems to include star imports, and in style remarks seems to reformat a lot of files to be inconsistent with the rest of the codebase. You should not run your autoformatter on this

Phoupraw commented 2 months ago

Can you receive the notification of my commits, or of only comments?

emilyploszaj commented 2 months ago

This looks relatively reasonable (though I don't know why I didn't mention that I don't use jetbrain contracts in my codebase), but I'd like to take a proper look at it after the noise of 1.20.5 has settled down. Thanks for sticking with me.