search

emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

Emi cheat mode can trigger UWRAD and kick player #516

Closed liangmoe closed 2 weeks ago

liangmoe commented 2 months ago

I tested both fabric and forge emi, and this would only happened with emi forge

Producs stepes: install forge emi and UWRAD, cheat item from emi's tab and get kicked

lates.log: https://mclo.gs/pDR4D3P

https://github.com/emilyploszaj/emi/assets/135343248/50f24c5f-1a01-4644-9f7d-74f08a3c38df

emilyploszaj commented 2 months ago

I'm unclear how this could be possible, EMI's packet application is handled by Forge's executor which has docs that promise the code is executed on the "main thread". Is this a bug in forge?

embeddedt commented 2 months ago

The call to handler.accept here is not wrapped in an execute call.

emilyploszaj commented 2 months ago

Oh this does not extend to neo. Why does forge have distinct read and application events if it's not going to wrap your application in an execute??

emilyploszaj commented 2 weeks ago

This was fixed in 1.1.7