search

emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
218 stars 45 forks source link

Legendary Tooltips Compatibility #521

Open LTCatt opened 2 months ago

LTCatt commented 2 months ago

It seems like Legendary Tooltips is unable to correctly get the rarity of items displayed on the EMI, causing it to display as "common rarity" style.

Inventory: image

EMI: image

peow commented 2 months ago

i think this is related to: https://github.com/emilyploszaj/emi/issues/256

From my own experience, it seems that the borders added by the mod bug with EMI, but not the borders added by Resource Packs, I recommend that you test some, like https://modrinth.com/resourcepack/eclectic-trove-legendary-tooltips

LTCatt commented 2 months ago

https://github.com/AHilyard/LegendaryTooltips/issues/88 It doesn't look like anyone's gonna fix it :/

LTCatt commented 2 months ago

Upon investigation, there is event parameter RenderTooltipEvent.Color event in onTooltipColorEvent. In EMI's tooltip, event.getItemStack() returns ItemStack.EMPTY, which causes this bug. So I think this is on EMI's side...

LTCatt commented 2 months ago

I built a very crude mixin that build a ItemStack from the translation key and passes it to Legendary Tooltips, which does get around the bug, but it's not a good solution. Tooltips.zip

peow commented 2 months ago

interesting

Burgersim commented 3 weeks ago

Was this every fixed or addressed? How would I as a user use that mixin?

LTCatt commented 3 weeks ago

you can't just use it. you have to complie it into a mod :/