emilyploszaj / emi

A featureful and accessible item and recipe viewer
MIT License
220 stars 46 forks source link

EMI crashes when hovering item with minecraft:hide_tooltip component (1.20.6, Fabric) #530

Closed Patbox closed 2 weeks ago

Patbox commented 2 months ago

EMI crashes when ItemStack with hide_tooltip component is hovered in inventory, if option for appending mod name enabled.

You can create this item with /give @p minecraft:sculk[minecraft:hide_tooltip={}]

It happens due to https://github.com/emilyploszaj/emi/blob/1.20.5/xplat/src/main/java/dev/emi/emi/mixin/ItemStackMixin.java#L25 being injected at both returns, one that uses List.of() for disabled tooltips and the old/regular one that uses ArrayList.

emilyploszaj commented 2 weeks ago

Should be fixed in 1.1.7